This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add linearizer on user ID to push rule PUT/DELETE requests #16052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
reviewed
Aug 3, 2023
| @@ -53,26 +54,32 @@ def __init__(self, hs: "HomeServer"): | |||
| self.notifier = hs.get_notifier() | |||
| self._is_worker = hs.config.worker.worker_app is not None | |||
| self._push_rules_handler = hs.get_push_rules_handler() | |||
| self._push_rule_linearizer = Linearizer(name="push_rules") | |||
There was a problem hiding this comment.
I'm not sure if it matters, but this won't fix the issue if there are multiple workers involved. Would it make more sense to lock the user's push rule rows?
There was a problem hiding this comment.
Yeah that's a good point, I'm basing the change entirley on the current state where push rules can only be modified on the main process, this only works while that limitation remains (does that block merging as-is, not sure?).
There was a problem hiding this comment.
I had assumed we could move these to workers, my fault for not checking!
erikjohnston
approved these changes
Aug 11, 2023
Co-authored-by: Erik Johnston <erikj@jki.re>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
See: #16053
Signed off by Nick @ Beeper (@Fizzadar)
(run the linters)