New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File upload size limit logic is broken (SYN-785) #1610

Open
matrixbot opened this Issue Oct 8, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@matrixbot
Member

matrixbot commented Oct 8, 2016

Submitted by @​matthew:matrix.org
It checks only content-length, which may lie. And it does so after the file has been uploaded, which is too late.

(Imported from https://matrix.org/jira/browse/SYN-785)

@matrixbot matrixbot changed the title from File upload size limit logic is broken (SYN-785) to File upload size limit logic is broken (https://github.com/matrix-org/synapse/issues/1610) Nov 7, 2016

@matrixbot matrixbot changed the title from File upload size limit logic is broken (https://github.com/matrix-org/synapse/issues/1610) to File upload size limit logic is broken (SYN-785) Nov 7, 2016

@PC-Admin

This comment has been minimized.

Show comment
Hide comment
@PC-Admin

PC-Admin Nov 1, 2017

I have been experiencing this bug since i first set up synapse.

Value is set to: max_upload_size: "10M"

Interestingly a @:matrix.org account can post up to 10MB files on a #:perthchat.org rooms, yet a perthchat user cannot post more then a 1MB file without experiencing:

The file ‘2m’ exceeds this home server’s size limit for uploads.

Any help fixing this issue is greatly appreciated, Matrix sucks when you can't upload files to it, and worse, the entire file tries to upload itself BEFORE telling you it cannot be done.

PC-Admin commented Nov 1, 2017

I have been experiencing this bug since i first set up synapse.

Value is set to: max_upload_size: "10M"

Interestingly a @:matrix.org account can post up to 10MB files on a #:perthchat.org rooms, yet a perthchat user cannot post more then a 1MB file without experiencing:

The file ‘2m’ exceeds this home server’s size limit for uploads.

Any help fixing this issue is greatly appreciated, Matrix sucks when you can't upload files to it, and worse, the entire file tries to upload itself BEFORE telling you it cannot be done.

@grafenhofer

This comment has been minimized.

Show comment
Hide comment
@grafenhofer

grafenhofer Nov 11, 2017

I can confirm this bug. I followed https://www.digitalocean.com/community/tutorials/how-to-install-matrix-synapse-on-ubuntu-16-04. I even tried to increase max_upload_size to "100M" - no success.

grafenhofer commented Nov 11, 2017

I can confirm this bug. I followed https://www.digitalocean.com/community/tutorials/how-to-install-matrix-synapse-on-ubuntu-16-04. I even tried to increase max_upload_size to "100M" - no success.

@grafenhofer

This comment has been minimized.

Show comment
Hide comment
@grafenhofer

grafenhofer Nov 11, 2017

Crap, I should have done more research: it is an nginx "issue". The server section of the nginx site config should in include the following (or a similar) line:

client_max_body_size 20M;

grafenhofer commented Nov 11, 2017

Crap, I should have done more research: it is an nginx "issue". The server section of the nginx site config should in include the following (or a similar) line:

client_max_body_size 20M;
@PC-Admin

This comment has been minimized.

Show comment
Hide comment
@PC-Admin

PC-Admin Nov 14, 2017

/etc/nginx/nginx.conf

then add the above line under "Basic Settings", works well

PC-Admin commented Nov 14, 2017

/etc/nginx/nginx.conf

then add the above line under "Basic Settings", works well

@pabelenda

This comment has been minimized.

Show comment
Hide comment
@pabelenda

pabelenda Jan 8, 2018

Is there any short/mid term plan for this issue?

pabelenda commented Jan 8, 2018

Is there any short/mid term plan for this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment