This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Register media URLs via regex. #16419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should actually be ready for a review now... the changes to the tests are really invasive, but I think they're overall better -- it means that we're not grabbing random resources and shoving requests into them but going through the routing path of Synapse. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This essentially converts the media repo stuff from the Twisted-way of registering resources to the regex way of registering servlets.
I tested this via trying some URLs with v1, v3, r0; testing that options still works, etc.
Vaguely related to #5118.
This is desirable for #15503 where a new endpoint (
/create) needs to be registered asv1& the behavior of/uploadis changed for/v3(to supportPUTin addition toPOST).