This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add type hints to synmark. #16421
Merged
Add type hints to synmark. #16421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMRobertson
reviewed
Oct 3, 2023
DMRobertson
reviewed
Oct 3, 2023
synmark/__main__.py
Outdated
|
|
||
| d.addBoth(on_done) | ||
| reactor.callWhenRunning(lambda: d.callback(True)) | ||
| reactor.run() | ||
|
|
||
| return d.result | ||
| return cast(float, d.result) |
There was a problem hiding this comment.
Surprised a cast is needed here. Any idea why?
There was a problem hiding this comment.
synmark/__main__.py:61: error: Incompatible return value type (got "object", expected "float") [return-value]
I think the Deferred isn't being properly marked as returning a float? (Maybe the Twisted trunk fixes this?)
There was a problem hiding this comment.
I couldn't quite figure this out, I think twisted trunk would fix it though.
DMRobertson
reviewed
Oct 3, 2023
DMRobertson
reviewed
Oct 3, 2023
DMRobertson
reviewed
Oct 3, 2023
DMRobertson
reviewed
Oct 4, 2023
| print(file_out.getvalue()) | ||
| reactor.stop() | ||
| return _ | ||
| return res | ||
|
|
||
| d.addBoth(on_done) | ||
| reactor.callWhenRunning(lambda: d.callback(True)) |
There was a problem hiding this comment.
Surprised mypy doesn't complain about feeding a bool into a Deferred[float]!
DMRobertson
approved these changes
Oct 4, 2023
|
I have! The logging suite seems broken unrelated to this PR so I Don't want to hold this up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was trying to figure out synmark the other day and type hints were helpful.