This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Convert simple_select_many_batch, simple_select_many_txn to tuples. #16444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
commented
Oct 6, 2023
DMRobertson
suggested changes
Oct 9, 2023
DMRobertson
reviewed
Oct 11, 2023
Comment on lines
-226
to
+231
| # We sort the rows so that the most recently added entry is picked up. | ||
| rows.sort(key=lambda r: r["ts_added_ms"]) | ||
| # We sort the rows by ts_added_ms so that the most recently added entry | ||
| # will stomp over older entries in the dictionary. | ||
| rows.sort(key=lambda r: r[2]) |
There was a problem hiding this comment.
Ohhhhh I see: key ids are not unique in this table.
We could probably get the DB to do that for us (e.g. https://stackoverflow.com/questions/13325583/postgresql-max-and-group-by) , but I doubt it makes much difference.
There was a problem hiding this comment.
It is annoying to do for both sqlite & postgres, I think. And I suspect Erik was attempting to not change too much code? Not 100% sure.
DMRobertson
approved these changes
Oct 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🪓
cursor_to_dict, more of #16431.This one got a bit big, but I couldn't really figure out a good way to separate them. It is fairly tedious, but I'll try to mark noticeable spots.