Update to Twisted-15.2.1.

[NegativeMjark]

Use Agent.usingEndpointFactory rather than accessing the internals of twisted to implement our own agent

[intelfx]

could you please also bump version in setup.py? otherwise, works for me, thanks.

[erikjohnston]

LGTM

[glyph]

Was just perusing this project (looks very cool!) and noticed it used Twisted; can I just say, it warms my heart that you folks are actually taking care to adopt new APIs like this! :-D

[ara4n]

@glyph :) Twisted has served us pretty well - thank you for creating it!

That said, we have been bitten pretty badly by https://twistedmatrix.com/trac/ticket/4362 (lack of IPv6 resolver for Agent) though - many people dismiss Matrix because of not supporting IPv6 for federation. If there is anything that can be done here we would owe you eternal thanks... O:-)

[glyph]

@glyph :) Twisted has served us pretty well - thank you for creating it!

Fantastic.

That said, we have been bitten pretty badly by https://twistedmatrix.com/trac/ticket/4362 (lack of IPv6 resolver for Agent) though - many people dismiss Matrix because of not supporting IPv6 for federation. If there is anything that can be done here we would owe you eternal thanks... O:-)

This is actually annoying me quite a bit as well! Honestly I'm kind of glad somebody noticed; IPv6 is so subtle and sadly niche that folks often don't notice it or don't think to report it.

In fact it's what I'm working on right now (although I'm addressing some infrastructure issues that make it hard to test first).

(You can read a bit more about my personal story with IPv6 here.)

[glyph]

At long last, we have a PR up for review… twisted/twisted#624

[glyph]

@ara4n - hopefully still in time for those eternal thanks? :)

[ara4n]

fantastic! we've been keeping half an eye on the progress of https://twistedmatrix.com/trac/ticket/4362, and meanwhile @kyrias was also looking at it a few days ago. Does this mean that we can just replace our current SSL4ClientEndpoint and TCP4ClientEndpoint from https://github.com/matrix-org/synapse/blob/master/synapse/http/endpoint.py#L16 with HostnameEndpoint and it may just magically work?! :D

Eternal thanks have been growing exponentially since we last spoke and should positively overflow once the PR lands!

[glyph]

@ara4n - It doesn't look like that's using Agent at all! The only place I see you using Agent in your codebase is here, which isn't calling into that endpoint-generating code at all...

Let me back up. The building blocks to do this yourself have existed for some time - the last block (wrapClientTLS) landed in 16.0, almost a year ago. What the PR I just referenced does is make Agent automatically use a fast endpoint, with TLS, by default. But the code you've got that doesn't use Agent doesn't need this - and in fact, won't benefit from it.

[glyph]

Probably it would be faster for me to send a quick proof-of-concept PR than to describe further...

[glyph]

Here's one - #1689

[glyph]

And here's another - #1690

[glyph]

Neither of those PRs actually work, and I imagine there's some re-tooling to be done on the test suite to get them to, but hopefully they should give you the idea that this should be really quite simple to implement.

[glyph]

On the HTTP client side, the twisted ticket PR has landed, so it should be available by default in the next release.