This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Send ALL membership events, including bans to the server that was banned #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send all membership changes to the server that was affected. This ensures that if the last member of a room on a server was kicked or banned they get told about it.
NegativeMjark
force-pushed
the
markjh/fix_ban_propagation
branch
from
88df242
to
b6b6771
Compare
richvdh
reviewed
Jan 4, 2017
| @@ -161,9 +161,11 @@ def notify_new_events(self, current_id): | |||
| get_domain_from_id(user_id) for user_id in users_in_room | |||
| ) | |||
|
|
|||
| # Send all membership changes to the server that was affected. | |||
| # This ensures that if the last member of a room on a server | |||
| # was kicked or banned they get told about it. | |||
There was a problem hiding this comment.
still wish we knew why Membership.JOIN had been special-cased previously :/
Rather than the state after then event.
|
I've removed the because it would only have been used to send a join event to a server that joined, and that server already has event because it created it. (all join events are created by the server that is joining the room.) |
This was referenced Jan 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.