This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
v2_alpha /register fixes for Application Services #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V2 Registration forced everyone (including ASes) to create a password for a user, when ASes should be able to omit passwords. Also unbreak AS registration in general which checked too early if the given username was claimed by an AS; it was checked before knowing if the AS was the one doing the registration! Add unit tests for AS reg, user reg and disabled_registration flag.
Namely this means using registration_handler.appservice_register.
|
LGTM |
dbkr
added a commit
that referenced
this pull request
Jul 29, 2015
v2_alpha /register fixes for Application Services
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application services currently do not work with
v2_alpha/registerendpoints as the logic to determine if they can register was wrong. In addition,v2_alphaforced ASes to specify a password for their virtual clients, when it should be possible to register without a password.This PR fixes these issues and tidies up the
synapse/rest/client/v2_alpha/register.pyin general. This tidying up mainly involved re-shuffling theon_POSTlogic to fork off to shared secret/AS logic ASAP so the bulk of the method remains purely for "normal" user logic. Previously, we were branching all over the method depending onis_application_serveroris_using_shared_secret. I've also taken the liberty of adding some unit tests for this file.I've also done the following manual tests:
enable_registration: falseenable_registration: false