Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Enable compression for federation by default in config #2434

Closed
lehmanju opened this issue Sep 1, 2017 · 6 comments
Closed

Enable compression for federation by default in config #2434

lehmanju opened this issue Sep 1, 2017 · 6 comments

Comments

@lehmanju
Copy link

lehmanju commented Sep 1, 2017

I think compression should be enabled by default for both, client and federation, because it reduces traffic. My own server does not seem to have higher cpu loads than normal and because it is enabled for clients by default i can't think of any reason not to enable it for federation.

@MacLemon
Copy link

MacLemon commented Sep 2, 2017

Since most of the c2s and s2s communication is text, it would greatly benefit in performance from the common gzip compression. I might even go as far as suggesting that there would be even more benefit in adding brotli compression which is supported by most browsers these days and certainly by Chrome/Electron which Riot is based upon.

It might be possible to add compression when synapsed is behind a reverse proxy like nginx, but of course not for outgoing requests.

@lehmanju
Copy link
Author

lehmanju commented Sep 3, 2017

Compression is already implemented but not enabled by default -> nginx/proxy is not strictly necessary

@zeratax
Copy link

zeratax commented Jun 20, 2020

is there any reason not to enable this?

@richvdh
Copy link
Member

richvdh commented Jun 22, 2020

http://breachattack.com/ possibly, but I don't think it applies here

@reivilibre
Copy link
Contributor

BREACH and CRIME seem like suitable enough reasons not to use compression; after all, we are combining compressible data from different users together in the same compressed stream and the length of the compressed payload is therefore a possibly exploitable side channel.
I would hesitate to enable, particularly by default, without a serious cryptographer's study of the impact.

@DMRobertson
Copy link
Contributor

Related: #13415 and #13537

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants