Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

<user id> should be removed from /admin/users/<user id> and /admin/users_paginate/<user id> #2522

Closed
turt2live opened this issue Oct 9, 2017 · 2 comments
Closed

<user id> should be removed from /admin/users/<user id> and /admin/users_paginate/<user id> #2522

turt2live opened this issue Oct 9, 2017 · 2 comments

Comments

@turt2live
Copy link
Member

The user ID is only used to verify the server. However, the server and user ID are both discarded immediately so the route can return a full list of users local to the homeserver.

What is the intention of the user ID parameter?
@richvdh
Copy link
Member

richvdh commented Oct 10, 2017

my question exactly: https://github.com/matrix-org/synapse/pull/1784/files/2849d3f29ddedaf35b0e080b02a40f8613fdba90#diff-024d1249ecb0742809d195f50ce4ec77

I kinda wish that #1784 hadn't been merged in its half-finished state. OTOH it did land some useful functionality.

@richvdh richvdh mentioned this issue Oct 10, 2017
Merged
@richvdh richvdh changed the title <user id> should be removed from /admin/users/<user id> <user id> should be removed from /admin/users/<user id> and /admin/users_paginate/<user id> Aug 8, 2018
@richvdh richvdh mentioned this issue Jun 19, 2019
Closed
@richvdh richvdh mentioned this issue Jul 22, 2019
Merged
@richvdh richvdh mentioned this issue Aug 28, 2019
Merged
3 tasks
This was referenced Aug 28, 2019
Closed
Merged
@richvdh
Copy link
Member

richvdh commented Dec 5, 2019

outdated now that #5925 has landed

@richvdh richvdh closed this as completed Dec 5, 2019
@richvdh richvdh mentioned this issue Feb 19, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turt2live @richvdh