This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Allow users to redact their own events #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: synapse/handlers/_base.py
| if user_level > redact_level: | ||
| return False | ||
|
|
||
| if EventID.from_string(event.redacts).domain == self.hs.get_config().server_name: |
There was a problem hiding this comment.
Why is this not:
EventID.from_string(event.redacts).domain == EventID.from_string(event.event_id).domain
Auth checks should not depend on the current server, as they need to come to the same answer on all servers in the room.
Federated servers still need to delegate authority to owning servers
|
LGTM |
illicitonion
added a commit
that referenced
this pull request
Sep 2, 2015
Allow users to redact their own events
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests in matrix-org/sytest#11
SYN-248