This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Make it possible to run tests against postgres #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests are failing because it expects #2830 to have landed |
erikjohnston
approved these changes
Jan 26, 2018
Configure the connectionpool used for unit tests to run the `on_new_connection` function.
richvdh
force-pushed
the
rav/postgres_in_tests
branch
from
d5fa1e0
to
f7b1c6f
Compare
... instead of creating our own special SQLiteMemoryDbPool, whose purpose was a bit of a mystery. For some reason this makes one of the tests run slightly slower, so bump the sleep(). Sorry.
richvdh
force-pushed
the
rav/postgres_in_tests
branch
from
f7b1c6f
to
88b9c5c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reshuffle the test deatabase setup so that you can run the synapse tests against postgres instead of sqlite.