Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Atomically persist events when joining a room over federation/ #283

Merged
merged 10 commits into from Oct 2, 2015
Merged

Atomically persist events when joining a room over federation/ #283

merged 10 commits into from Oct 2, 2015

Conversation

erikjohnston
Copy link
Member

Review on Reviewable

@illicitonion
Copy link
Contributor

I certainly don't understand all of the subtleties, but seems reasonable... LGTM?

NegativeMjark
NegativeMjark reviewed Sep 18, 2015
View reviewed changes
synapse/handlers/federation.py
a = {
(event_map[e_id].type, event_map[e_id].state_key): event_map[e_id]
for e_id, _ in e.auth_events
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer a more meaningful variable name than a.

@NegativeMjark
Copy link
Contributor

Other than the short variable names and lack of commentary it LGTM.

@erikjohnston
Copy link
Member Author

Other than the short variable names and lack of commentary it LGTM.

Done

erikjohnston added a commit that referenced this pull request Oct 2, 2015
@erikjohnston
Merge pull request #283 from matrix-org/erikj/atomic_join_federation
5879edb 
Atomically persist events when joining a room over federation/
@erikjohnston erikjohnston merged commit 5879edb into develop Oct 2, 2015
illicitonion added a commit that referenced this pull request Oct 6, 2015
@illicitonion
Revert "Merge pull request #283 from matrix-org/erikj/atomic_join_fed…
34d26d3 
…eration"

This reverts commit 5879edb, reversing
changes made to b43930d.
illicitonion added a commit that referenced this pull request Oct 6, 2015
@illicitonion
Revert "Revert "Merge pull request #283 from matrix-org/erikj/atomic_…
d4bb28c 
…join_federation""

This reverts commit 34d26d3.
@erikjohnston erikjohnston deleted the erikj/atomic_join_federation branch November 19, 2015 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erikjohnston @illicitonion @NegativeMjark