This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Use StateResolutionHandler to resolve state in persist_events #2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rejig the if statements to simplify the logic and reduce indentation
... and thus benefit (hopefully) from its cache.
erikjohnston
approved these changes
Feb 13, 2018
synapse/storage/events.py
Outdated
| # I don't think this can happen, but let's double-check | ||
| raise Exception( | ||
| "Context for new extremity event %s has no state " | ||
| "group" % event_id, |
There was a problem hiding this comment.
Nit: I do prefer always using tuples rather than relying on strings working.
There was a problem hiding this comment.
as in you'd prefer (event_id, ) ?
There was a problem hiding this comment.
Generally yes, (or (event_id,) without the space), as its very confusing if there is a bug and event_id suddenly becomes iterable and then the logging explodes. In this particular case its probably fine though
synapse/storage/events.py
Outdated
| @@ -586,6 +586,7 @@ def get_events(ev_ids): | |||
|
|
|||
| current_state = yield resolve_events_with_factory( | |||
| state_sets, | |||
| event_map={}, | |||
There was a problem hiding this comment.
Should this be None to be a bit more consistent?
There was a problem hiding this comment.
plausibly, but it's replaced in ebfe64e anyway
There was a problem hiding this comment.
Yup, didn't realise until after i had submitted the review
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and thus benefit (hopefully) from its cache.