This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Split AS stores #2901
Merged
Split AS stores #2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/split_as_stores
branch
from
e93e26f
to
46244b2
Compare
erikjohnston
commented
Feb 21, 2018
synapse/storage/appservice.py
Outdated
|
|
||
|
|
||
| class ApplicationServiceTransactionStore(ApplicationServiceTransactionWorkerStore): | ||
| pass |
There was a problem hiding this comment.
Should I remove this and replace it everywhere with ApplicationServiceTransactionWorkerStore?
There was a problem hiding this comment.
I wouldn't, because: (a) consistency with the other stores (b) at some point we might want to do something that needs to not be on the workers (c) it would be a faff
There was a problem hiding this comment.
a comment to clarify mightn't hurt.
erikjohnston
force-pushed
the
erikj/split_as_stores
branch
from
695d306
to
6ae9a3d
Compare
richvdh
approved these changes
Feb 26, 2018
synapse/storage/appservice.py
Outdated
|
|
||
|
|
||
| class ApplicationServiceTransactionStore(ApplicationServiceTransactionWorkerStore): | ||
| pass |
There was a problem hiding this comment.
I wouldn't, because: (a) consistency with the other stores (b) at some point we might want to do something that needs to not be on the workers (c) it would be a faff
synapse/storage/appservice.py
Outdated
|
|
||
|
|
||
| class ApplicationServiceTransactionStore(ApplicationServiceTransactionWorkerStore): | ||
| pass |
There was a problem hiding this comment.
a comment to clarify mightn't hurt.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still has a dependency on_get_events, so we should probably wait until I've factored that out before looking at this.Includes #2902