Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix missing invalidations for receipt storage #2904

Merged
merged 1 commit into from Feb 27, 2018
Merged

Fix missing invalidations for receipt storage #2904

merged 1 commit into from Feb 27, 2018

Conversation

erikjohnston
Copy link
Member

No description provided.

richvdh
richvdh approved these changes Feb 27, 2018
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sensible.

What sort of issues would this have caused? It'd be helpful to have them here for the record.

@richvdh richvdh assigned erikjohnston and unassigned richvdh Feb 27, 2018
@erikjohnston
Copy link
Member Author

What sort of issues would this have caused? It'd be helpful to have them here for the record.

None, it only affects if you calculate push rules on the workers, which hasn't landed yet. The issue would manifest as users not getting unread notifications for a new room (if the user didn't have a pusher set up).

@erikjohnston erikjohnston merged commit 3594dbc into develop Feb 27, 2018
@erikjohnston erikjohnston deleted the erikj/receipt_cache_invalidation branch March 5, 2018 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erikjohnston @richvdh