This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Calculate stream_ordering_month_ago correctly on workers #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Mar 1, 2018
| def __init__(self, db_conn, hs): | ||
| super(EventPushActionsWorkerStore, self).__init__(db_conn, hs) | ||
|
|
||
| # These get correctly ste by _find_stream_orderings_for_times_txn |
|
|
||
| # These get correctly ste by _find_stream_orderings_for_times_txn | ||
| self.stream_ordering_month_ago = 0 | ||
| self.stream_ordering_day_ago = 0 |
There was a problem hiding this comment.
we have code here which appears to expect this to be initialised to None (though I see no evidence of it being intialised at all, so perhaps it was just broken before)
There was a problem hiding this comment.
Ah, may as well set it to None. I think before we didn't call _find_stream_orderings_for_times_txn on start up whereas now we do, so that code won't be hit currently.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked the logs and it doesn't look like it takes long at all to calculate these so I don't think it matters if we start calculating these on workers too.