Provide ability to login using CAS #295
Conversation
|
Can one of the admins verify this patch? |
|
Marrixbot: ok to test |
| @@ -67,6 +77,16 @@ def on_POST(self, request): | |||
| "uri": "%s%s" % (self.idp_redirect_url, relay_state) | |||
| } | |||
| defer.returnValue((200, result)) | |||
| elif self.cas_enabled and (login_submission["type"] == | |||
| LoginRestServlet.CAS_TYPE): | |||
| url = "%s/proxyValidate" % (self.cas_server_url) | |||
There was a problem hiding this comment.
FYI, there should be a comma after self.cas_server_url to make it a tuple, otherwise the brackets don't actually do anything here.
There was a problem hiding this comment.
This code has changed in 059bb26.
|
This looks perfectly reasonable once |
|
LGTM |
|
LGTM, other than the merge conflicts |
|
@stevenhammerton If you could fix the conflict, we'll merge it in :) |
|
@erikjohnston - Fixed conflict by rebase, hope that's okay although I realise you'll probably need to give it a once over again because of that :( |
|
@stevenhammerton Ah well, it's not a a particularly large PR at least. Well, this LGTM! Thanks again :) |
Provide ability to login using CAS
Initial support for CAS login.
Important! - Will login as the user returned from CAS. So if that user already exists, CAS login will login with that account. If no user yet exists with the user returned from CAS, we register and then login.
Doesn't handle CAS logout or anything like that yet, just simple login.
There will be further pull requests for matrix-js-sdk and matrix-react-sdk to show support there.
I've tested this locally using OpenMarket CAS and manually hitting APIs and it appears to work.
Any questions, let me know.
Signed-off-by: Steven Hammerton steven.hammerton@openmarket.com