This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add room_id to the response of rooms/{roomId}/join
#2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
As you note, it seems a bit pointless, but it's nice to be compliant with the spec. Looks good to me - please can you sign it off as per https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst?
A PR against matrix-doc, possibly preceded by discussion in #matrix-architecture:matrix.org, is the easiest way. |
|
@matrixbot: test this please |
|
@matrixbot: retest this please |
|
@richvdh I have added the |
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2349
This endpoint requires the room_id to be known on the client side anyway, so it might make sense to remove it in a future revision of the spec. If there is an easy way to propose small changes like this, let me know.
Signed-off-by: Jonas Platte