Replace old style error catching with 'as' keyword #3000
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
thanks, but please could you see https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst - particularly regarding (a) PRing against develop and (b) signing off your contribution. Sorry! |
|
Oh, right I should probably have checked that (edit: oh, right, I used the CLI to pr). Are you fine with force-pushing pull request branches? I assume so. |
This is both easier to read and compatible with python3 (not that that matters) Signed-off-by: Adrian Tschira <nota@notafile.com>
NotAFile
force-pushed
the
change-except-style
branch
from
5b669f2
to
2cc9f76
Compare
|
I've fixed this according to your requirements. I though it would notify you automatically when I push, but it seems not, so here's a manual notification. |
|
thanks! [I wonder if there is a way to enforce this with flake8] |
|
One way would be running tests under py3 :) |
Yup. As soon as you've got the unit tests passing under py3, I'd be up for running them under py3 on Travis, even if we're a way off getting sytest passing. |
This is both easier to read and compatible with python3 (not that that
matters)