This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Replace ujson with simplejson #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Mar 16, 2018
synapse/storage/events.py
Outdated
| @@ -56,7 +56,7 @@ | |||
|
|
|||
| def encode_json(json_object): | |||
| if USE_FROZEN_DICTS: | |||
| # ujson doesn't like frozen_dicts | |||
| # simplejson doesn't like frozen_dicts | |||
There was a problem hiding this comment.
D'oh, I thought i'd explicitly not changed that :/
krombel
added a commit
to krombel/synapse
that referenced
this pull request
Mar 22, 2018
Changes in synapse v0.27.0-rc2 (2018-03-19) =========================================== Pulls in v0.26.1 Bug fixes: * Fix bug introduced in v0.27.0-rc1 that causes much increased memory usage in state cache (PR matrix-org#3005) Changes in synapse v0.26.1 (2018-03-15) ======================================= Bug fixes: * Fix bug where an invalid event caused server to stop functioning correctly, due to parsing and serializing bugs in ujson library (PR matrix-org#3008)
|
For the record: The problem here was that somebody sent an event with a long long int in it. Contrary to what is specified in Canonical JSON, we do not in fact check the size of any ints beng encoded, so the signature on the event was accepted regardless. Then, when we came to encode the event for sending out over |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.