Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Don't support limitless pagination #3265

Merged
merged 2 commits into from May 22, 2018
Merged

Conversation

erikjohnston
Copy link
Member

The pagination storage function supported not specifiying a limit on the
number of events returned. This was triggered when using the search or
context API with a limit of zero, which the storage function took to
mean not being limited.

The pagination storage function supported not specifiying a limit on the
number of events returned. This was triggered when using the search or
context API with a limit of zero, which the storage function took to
mean not being limited.
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm

@erikjohnston erikjohnston merged commit 35ca3e7 into develop May 22, 2018
@rubo77
Copy link
Contributor

rubo77 commented May 23, 2018

Where do you set this limit?

@erikjohnston erikjohnston deleted the erikj/limit_pagination branch September 20, 2018 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants