Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

make prometheus_client (and possibly other metric related dependencies) optional if metrics are disabled #4845

Open
gordon-quad opened this issue Mar 10, 2019 · 0 comments
Open

make prometheus_client (and possibly other metric related dependencies) optional if metrics are disabled #4845

gordon-quad opened this issue Mar 10, 2019 · 0 comments
Labels
A-Metrics metrics, measures, stuff we put in Prometheus T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. z-bug (Deprecated Label) z-p2 (Deprecated Label)

Comments

@gordon-quad
Copy link

Synapse refuse to start if prometheus_client is not installed even if metrics are disabled. However if you modify python_dependencies.py and remove this dependency it functions well without it.

Can you make this dependency check for prometheus_client optional only if metrics are enabled?
@neilisfragile neilisfragile added z-bug (Deprecated Label) z-p2 (Deprecated Label) labels Mar 12, 2019
@MadLittleMods MadLittleMods added A-Metrics metrics, measures, stuff we put in Prometheus T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. labels Nov 10, 2021
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Metrics metrics, measures, stuff we put in Prometheus T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. z-bug (Deprecated Label) z-p2 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gordon-quad @neilisfragile @MadLittleMods