Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

We should never send events in blocked rooms to clients #4909

Open
2 tasks
erikjohnston opened this issue Mar 21, 2019 · 0 comments
Open
2 tasks

We should never send events in blocked rooms to clients #4909

erikjohnston opened this issue Mar 21, 2019 · 0 comments
Labels
A-Context-Endpoint /context client API endpoint A-Moderation Tools for moderating HSes: event redaction, media removal, purge admin API, reports from users, ... A-Sync defects related to /sync O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@erikjohnston
Copy link
Member

Currently we only block join/invites and peeking to blocked rooms, but other APIs will probably still let you get at the data

  • Filter out all events in blocked rooms
  • Block /context requests to blocked rooms

c.f. #4908
@neilisfragile neilisfragile added z-bug (Deprecated Label) z-p2 (Deprecated Label) labels Mar 25, 2019
@MadLittleMods MadLittleMods added A-Moderation Tools for moderating HSes: event redaction, media removal, purge admin API, reports from users, ... A-Sync defects related to /sync T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. A-Context-Endpoint /context client API endpoint labels May 16, 2022
@erikjohnston erikjohnston added S-Minor Blocks non-critical functionality, workarounds exist. O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed z-bug (Deprecated Label) z-p2 (Deprecated Label) labels Nov 15, 2022
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Context-Endpoint /context client API endpoint A-Moderation Tools for moderating HSes: event redaction, media removal, purge admin API, reports from users, ... A-Sync defects related to /sync O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neilisfragile @MadLittleMods @erikjohnston