This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Exclude soft-failed events from fwd-extremity candidates. #5146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When considering the candidates to be forward-extremities, we must exclude soft failures. Hopefully fixes #5090.
Codecov Report
@@ Coverage Diff @@
## develop #5146 +/- ##
===========================================
- Coverage 62.48% 62.47% -0.01%
===========================================
Files 338 338
Lines 35035 35036 +1
Branches 5734 5734
===========================================
Hits 21890 21890
- Misses 11596 11599 +3
+ Partials 1549 1547 -2 |
|
Out of interest: if one were to run this without waiting for tests, what sorts of problems could be expected? Answers such as "please oh god don't do that" and "your server may never turn on again" are acceptable. |
Worst case, it will spew exceptions throughout your logs and fail to respond. Nothing that couldn't be fixed with a rollback. |
|
Seems to work. Test now at matrix-org/sytest#609. |
erikjohnston
approved these changes
May 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When considering the candidates to be forward-extremities, we must exclude soft
failures.
This is currently totally untested, but hopefully fixes #5090. I'm hoping to write a sytest to reproduce the problem and prove it fixed.