This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Expose DataStore._get_events as get_events_as_list #5184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for reaction work which requires it.
Codecov Report
@@ Coverage Diff @@
## develop #5184 +/- ##
========================================
Coverage 62.15% 62.15%
========================================
Files 336 336
Lines 34659 34659
Branches 5694 5694
========================================
Hits 21541 21541
Misses 11583 11583
Partials 1535 1535 |
richvdh
approved these changes
May 15, 2019
| # go and fetch the relevant row from the db, but it would be nice | ||
| # to think about how we can cache this rather than hit the db | ||
| # every time we access a redaction event. | ||
| # For now (quick hack to fix during 0.99 release cycle), we |
There was a problem hiding this comment.
oh god, it's another "quick hack" which will be biting us in 5 years time, isn't it
Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for reaction work which requires it.