Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Message Editing: Block attempts to edit other people's edits via /_matrix/client/v3/rooms/{roomId}/send #5364

Open
jryans opened this issue Jun 5, 2019 · 5 comments
Labels
P5 (OBSOLETE: use S- labels.) Dubious backlog: will not schedule, but may consider patches T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@jryans
Copy link
Contributor

jryans commented Jun 5, 2019

I can't quite recall where we left this, so filing an issue to track...

It looks like Synapse currently ignores edits from other senders (those who did not send the original message) when constructing the data to bundled into original event. However edits from others currently still come through on the timeline.

We should block edits from other senders in the timeline as well (or even at send time if possible)

@Half-Shot
Copy link
Collaborator

If we want to enforce this, it should probably be a spec item. Last time this came up though, I remember a lot of people had use cases for editing other's messages (multiple admins editing a pinned message came to mind).

@jryans
Copy link
Contributor Author

jryans commented Jun 10, 2019

I have added a comment about this on the aggregations MSC.

@chagai95
Copy link
Contributor

chagai95 commented Dec 3, 2021

(multiple admins editing a pinned message came to mind).

This is a great use case, there is a precedent for this on telegram channels, I used it and would love to see this possible on matrix 🙃

@H-Shay H-Shay added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Jan 13, 2022
@thebiblelover7
Copy link

Is this going to be possible anytime soon? I would really like to have this as a kind of "telegram channel" functionality like @ chagai95 said.

@richvdh richvdh changed the title Message Editing: Block edits from other senders Message Editing: Block attempts to edit other people's edits via /_matrix/client/v3/rooms/{roomId}/send May 17, 2022
@richvdh
Copy link
Member

richvdh commented May 17, 2022

We should block edits from other senders in the timeline as well (or even at send time if possible)

I don't particularly agree that homeservers should be responsible for blocking malformed edits, for the reasons set out in MSC2801.

We could certainly block attempts to send such edits via the C-S API, though I don't think it will be much use (given we can't block such events over federation).

@richvdh richvdh added the P5 (OBSOLETE: use S- labels.) Dubious backlog: will not schedule, but may consider patches label May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P5 (OBSOLETE: use S- labels.) Dubious backlog: will not schedule, but may consider patches T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests

6 participants