Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

The account validity admin route returns 200 OK even if the feature is turned off in the config #6128

Open
babolivier opened this issue Sep 27, 2019 · 0 comments
Open

The account validity admin route returns 200 OK even if the feature is turned off in the config #6128

babolivier opened this issue Sep 27, 2019 · 0 comments
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. z-bug (Deprecated Label) z-p2 (Deprecated Label)

Comments

@babolivier
Copy link
Contributor

There must be a if not hs.config.account_validity.enabled: return somewhere in one of the functions called (directly and indirectly) by the endpoint, which means that a call to /_synapse/admin/v1/account_validity/validity will result in the same response as if the feature was enabled.
@neilisfragile neilisfragile added z-bug (Deprecated Label) z-p2 (Deprecated Label) labels Oct 2, 2019
@reivilibre reivilibre added S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. O-Uncommon Most users are unlikely to come across this or unexpected workflow labels May 23, 2023
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. z-bug (Deprecated Label) z-p2 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neilisfragile @babolivier @reivilibre