This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Sanity-check room ids in event auth #6530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we do an event auth operation, check that all of the events involved are in the right room.
erikjohnston
approved these changes
Dec 12, 2019
| # sanity-check it | ||
| for auth_event in auth_events.values(): | ||
| if auth_event.room_id != room_id: | ||
| raise Exception( |
There was a problem hiding this comment.
given that I think the problem has happened somewhere else if we get this far, I think a 500 is more appropriate. Consider it as an assertion.
Tbh I think that our habit of trying to decide what HTTP error codes we should return in the depths of utility functions is an anti-pattern.
richvdh
added a commit
that referenced
this pull request
Dec 16, 2019
When we do an event auth operation, check that all of the events involved are in the right room.
richvdh
added a commit
that referenced
this pull request
Dec 18, 2019
Synapse 1.7.1 (2019-12-18) ========================== This release includes several security fixes as well as a fix to a bug exposed by the security fixes. Administrators are encouraged to upgrade as soon as possible. Security updates ---------------- - Fix a bug which could cause room events to be incorrectly authorized using events from a different room. ([\#6501](#6501), [\#6503](#6503), [\#6521](#6521), [\#6524](#6524), [\#6530](#6530), [\#6531](#6531)) - Fix a bug causing responses to the `/context` client endpoint to not use the pruned version of the event. ([\#6553](#6553)) - Fix a cause of state resets in room versions 2 onwards. ([\#6556](#6556), [\#6560](#6560)) Bugfixes -------- - Fix a bug which could cause the federation server to incorrectly return errors when handling certain obscure event graphs. ([\#6526](#6526), [\#6527](#6527))
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '971a0702b': Sanity-check room ids in event auth (#6530)
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '6577f2d88': Sanity-check room ids in event auth (#6530)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we do an event auth operation, check that all of the events involved are
in the right room.