Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

is there something we can do to ignore state resets in old room versions? #6903

Open
ara4n opened this issue Feb 12, 2020 · 3 comments
Open
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. z-p2 (Deprecated Label)

Comments

@ara4n
Copy link
Member

ara4n commented Feb 12, 2020

if our server has accepted a room upgrade event for a given room, should we not ignore events in the older versions of that room (and thus mitigate users being state-reset into the current version of the room because they were once in a v1 version of that room?

@turt2live
Copy link
Member

Riot could also keep better track of the upgrade chain by shoving it into account data. Then it just treats the account data chain as gospel instead of the state of the room. Risk would be malicious server admins trying to hide rooms with it, but that feels a bit like a minor concern given the security model says you trust your server admin for a lot more (and they could just hide it in other ways)

@richvdh
Copy link
Member

richvdh commented Feb 12, 2020

I think we'd have to change both sides, but yes, maybe we could change the protocol so that once a tombstone arrives, we never send any events over federation. could be a bit gnarly though.

@richvdh richvdh added z-feature (Deprecated Label) z-p2 (Deprecated Label) labels Feb 14, 2020
@Mikaela
Copy link
Contributor

Mikaela commented Aug 19, 2021

This would be nice as I keep finding myself from state-reset Fedora room version 1 every one in a while and I would really like to get out of it permanently instead of occasionally asking there what the room is and why am I joined there.

([state-reset Fedora room version 1](matrix:roomid/sWugvEqzNjUsmflyPC:matrix.org?via=matrix.org) looks like GitHub doesn't render Matrix URIs by the way.)

@erikjohnston erikjohnston added T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. and removed z-feature (Deprecated Label) labels Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. z-p2 (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

5 participants