This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Send email notifications for missed messages #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly logic of when to send an email
Copy the stuff over from http pusher that prevents multiple instances of process running at once and sets up logging and measure blocks.
Also pep8 fixes
Mostly WIP porting the room name calculation logic from the web client so our room names in the email mirror the clients.
Doesn't get character enocind right yet but makes it not error.
So names of people in a room are given in order
Include name of the person we're sending to and add summary text at the top giving an overview of what's happened.
Add public facing base url to the server so synapse knows what URL to use when converting mxc to http urls for use in emails
Say who the messages are from if there's no room name, otherwise it's a bit nonsensical
so we don't accidentally mail out events people shouldn't see
|
@NegativeMjark: How does packaging work with the manifest stuff? I note that all the static content is in a top level |
In standard sql, join binds tighter than comma, so we were joining on the wrong table. Postgres follows the standard (apparently).
until we can de-dup between the context and other notifs
switch to vector.im permalinks as matrix.to isn't ready yet. merge overlapping notifications together. give one message of context after a notification (in the unlikely event it exists, but it's possible thanks to throttling). include name of app in mail templates
|
lgtm |
…k aka Word Remove templates-vector and theme templates with variables instead Switch to matrix.to URLs by default for links
…ok aka Word
Remove templates-vector and theme templates with variables instead
Switch to matrix.to URLs by default for links
This was referenced Jun 29, 2017
|
How to debug this in case it doesn't work? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most functionality here is confined to adding an email pusher and other functionality used from it. Changes to the rest of the codebase are limited to exposing the previously private _filter_events_for_client and adding an email pusher for new users who register with an email.
This code will not be enabled unless the appropriate options are added to the config on existing installations. They are disabled by default on new installations.
Newly registered users will only have an email pusher set up if email notifications are enabled on the Home Server, so users will only ever start getting mails after registering or explicitly opting in.
Fixes element-hq/element-web#108