This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add types to the server code and remove unused parameter #7813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
previously requested changes
Jul 10, 2020
synapse/http/server.py
Outdated
| response_code_message: Optional[str] = None, | ||
| pretty_print: bool = False, | ||
| canonical_json: bool = True, | ||
| ) -> NOT_DONE_YET: |
There was a problem hiding this comment.
Looks like this function also returns None below
There was a problem hiding this comment.
So I ended up removing this since NOT_DONE_YET is a constant, not a type and...mypy somewhat gets confused if you try to put Optional[] around it or anything. I added back some comments too.
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
clokep
dismissed
anoadragon453’s stale review
Dismissing since richvdh reviewed.
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'd9e47af61': Add types to the server code and remove unused parameter (#7813)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two unrelated things, minus them being in the same code:
response_code_message, which is unused.