Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Improve MatrixError when user tries to create an account with digits only #8125

Closed
bmarty opened this issue Aug 19, 2020 · 1 comment · Fixed by #8135
Closed

Improve MatrixError when user tries to create an account with digits only #8125

bmarty opened this issue Aug 19, 2020 · 1 comment · Fixed by #8135
Assignees
@clokep
Labels
Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution

Comments

@bmarty
Copy link

bmarty commented Aug 19, 2020

Could be nice to send errcode M_INVALID_USERNAME, for the moment, the client receives M_UNKNOWN:

{"errcode":"M_UNKNOWN","error":"Numeric user IDs are reserved for guest users."}

Originally posted by @bmarty in #7625 (comment)
@bmarty bmarty mentioned this issue Aug 19, 2020
Closed
@clokep clokep added the Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution label Aug 19, 2020
@bmarty bmarty changed the title Improve MatrixError when user tries to create an accoutn with digits only Improve MatrixError when user tries to create an account with digits only Aug 19, 2020
@bmarty
Copy link
Author

bmarty commented Aug 19, 2020

A similar fix has been done here if it helps: https://github.com/matrix-org/synapse/pull/6151/files

@clokep clokep self-assigned this Aug 20, 2020
@clokep clokep mentioned this issue Aug 20, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the error code when trying to register with a name reserved for guests. matrix-org/synapse
2 participants
@clokep @bmarty