This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Register a device_id in the /v2/register flow. #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't cover *all* of the registration flows, but it does cover the most common ones: in particular: shared_secret registration, appservice registration, and normal user/pass registration. Pull device_id from the registration parameters. Register the device in the devices table. Associate the device with the returned access and refresh tokens. Profit.
| @@ -236,7 +237,7 @@ def on_POST(self, request): | |||
| add_email = True | |||
|
|
|||
| result = yield self._create_registration_details( | |||
| registered_user_id | |||
| registered_user_id, body | |||
There was a problem hiding this comment.
Wait, this isn't going to work in the case where a user's account is registered after they come back from verifying their email address, where the parameters to registration will come out of check_auth )params, not the body of the current request.
There was a problem hiding this comment.
Right, yes. I think the way I've implemented this in the js-sdk (matrix-org/matrix-js-sdk#151) means it will actually send a device_id in the follow-up request, but ISWYM.
I think I want to add some sytests to this though, so that I know what I'm doing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't cover all of the registration flows, but it does cover the most
common ones: in particular: shared_secret registration, appservice
registration, and normal user/pass registration.
Pull device_id from the registration parameters. Register the device in the
devices table. Associate the device with the returned access and refresh
tokens. Profit.