Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

class in test_responsecache.py has the wrong name (DeferredCacheTestCase instead of ResponseCacheTestCase) #9738

Closed
ShadowJonathan opened this issue Apr 3, 2021 · 1 comment · Fixed by #10157
Closed

class in test_responsecache.py has the wrong name (DeferredCacheTestCase instead of ResponseCacheTestCase) #9738

ShadowJonathan opened this issue Apr 3, 2021 · 1 comment · Fixed by #10157
Assignees
@ShadowJonathan
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@ShadowJonathan
Copy link
Contributor

ShadowJonathan commented Apr 3, 2021 •
edited
Loading

This is my own fault, but i'm putting it here because i noticed it while working on something else.

The file under tests/util/caches/test_responsecache.py uses DeferredCacheTestCase, test_deferred_cache.py also uses this classname, so it has to be ResponseCacheTestCase instead.
@ShadowJonathan
Copy link
Contributor Author

(@ who triages this, could you assign me to the issue?)

@clokep clokep added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Apr 5, 2021
@richvdh richvdh mentioned this issue Jun 10, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ShadowJonathan ShadowJonathan

Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extend ResponseCache to pass a context object into the callback matrix-org/synapse
2 participants
@clokep @ShadowJonathan