Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

The last to_device message comes down initial sync #9767

Open
erikjohnston opened this issue Apr 8, 2021 · 0 comments
Open

The last to_device message comes down initial sync #9767

erikjohnston opened this issue Apr 8, 2021 · 0 comments
Labels
S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@erikjohnston
Copy link
Member

@manuroe discovered this while writing integration tests:

so, FTR, synapse seems to always send the last to_device event for an initial sync even after several incremental syncs after I receive this to_device
if there is a new to_device event in those intermediate incremental syncs, the initial sync will not return my first to_device event but only the second one
I have my initial data for my test. I am happy now but I just wanted to share it here
I tested it against Synapse/develop

It's possible that this is happening because the global to_device token isn't incremented as no other to device messages are sent, but 🤷

@erikjohnston erikjohnston added S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

No branches or pull requests

1 participant