Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Dynamically fetch oembed provider metadata (for url previews) #9877

Open
ShadowJonathan opened this issue Apr 23, 2021 · 3 comments
Open

Dynamically fetch oembed provider metadata (for url previews) #9877

ShadowJonathan opened this issue Apr 23, 2021 · 3 comments
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@ShadowJonathan
Copy link
Contributor

ShadowJonathan commented Apr 23, 2021

it might be nice to be able to specify custom hooks in synapse's configuration, although I'm not sure if that's really worth the effort.

This shouldn't be too hard, it would also be nice to default to using the documented providers (https://oembed.com/providers.json).

Originally posted by @clokep in #9733 (comment)


Fetching this, and refreshing every week or so, could give better experience to users for embeds, I think adding this would help a lot with miscellaneous embedding problems users might not report, and instead "magically" make each one of them work for their favourite websites.

@ShadowJonathan ShadowJonathan changed the title Dynamically fetch oembed provider metadata Dynamically fetch oembed provider metadata (for url previews) Apr 23, 2021
@anoadragon453 anoadragon453 added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Apr 27, 2021
@anoadragon453
Copy link
Member

For clarity, Synapse already supports oEmbed previews as of #7920, but this is currently limited to a list of non-configurable providers (e.g twitter).

This issue suggests having the configuration be fetched from https://oembed.com/providers.json, which is updated regularly and recommended by the oEmbed spec.

Sounds like a pretty good idea to me, honestly.

@clokep
Copy link
Contributor

clokep commented Apr 27, 2021

I think there was a discussion somewhere (maybe in #7920?) of allowing users to add entries to the list via the config file too. A bit orthogonal to this issue, but thought it was worth mentioning.

@richvdh
Copy link
Member

richvdh commented Aug 6, 2021

related: #9733, #2752

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests

4 participants