Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add knock to event_creator #1332

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Add knock to event_creator #1332

merged 2 commits into from
Mar 2, 2023

Conversation

dklimpel
Copy link
Contributor

@dklimpel dklimpel requested a review from a team as a code owner February 23, 2023 07:03
@dklimpel dklimpel mentioned this pull request Feb 23, 2023
Merged
4 tasks
@clokep clokep assigned clokep and unassigned clokep Feb 23, 2023
@clokep clokep requested review from clokep and removed request for a team February 23, 2023 18:11
@dklimpel dklimpel marked this pull request as draft February 24, 2023 06:01
@dklimpel dklimpel marked this pull request as ready for review February 28, 2023 06:20
clokep
clokep approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine if matrix-org/synapse#15133 is OK.

@clokep clokep merged commit 160dde0 into matrix-org:develop Mar 2, 2023
@dklimpel dklimpel deleted the patch-1 branch March 2, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clokep clokep clokep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dklimpel @clokep