Test that remote invites are correctly pushed #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand why there are new failures for Dendrite? |
| @@ -630,3 +630,103 @@ sub check_received_push_with_name | |||
| ); | |||
| }); | |||
| }; | |||
|
|
|||
| test "Invites over federation are correctly pushed", | |||
There was a problem hiding this comment.
Are we making more Sytest tests because there isn't a good way to test push gateway stuff in Complement?
| @@ -630,3 +630,103 @@ sub check_received_push_with_name | |||
| ); | |||
| }); | |||
| }; | |||
|
|
|||
| test "Invites over federation are correctly pushed", | |||
There was a problem hiding this comment.
Suggested change
| test "Invites over federation are correctly pushed", | |
| test "Invites over federation are correctly pushed (without room_name)", |
| }; | ||
|
|
||
|
|
||
| test "Invites over federation are correctly pushed with name", |
There was a problem hiding this comment.
Suggested change
| test "Invites over federation are correctly pushed with name", | |
| test "Invites over federation are correctly pushed (with room_name)", |
MadLittleMods
approved these changes
Jun 28, 2023
S7evinK
added a commit
to matrix-org/dendrite
that referenced
this pull request
Sep 26, 2023
The tests added in matrix-org/sytest#1356 uncovered that we don't consider invitations as events the userapi should handle and thus just don't notify the client about any new invitations received over federation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for matrix-org/synapse#15820