New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add better support for coverage in CI #529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks plausible otherwise
docker/synapse_sytest.sh
Outdated
# Upload coverage to codecov, if running on CircleCI | ||
if [ -n "$CIRCLECI" ] | ||
then | ||
/venv/bin/coverage combine || IGN=$? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/venv/bin/coverage combine || IGN=$? | |
/venv/bin/coverage combine || true |
Although, why do we want to ignore the error here and not at line 80?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codecov doesn't return non-0 if it fails searching, only if it fails uploading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too manynegatives I think ... this line is a search rather than an upload? So according to what you wrote, it always returns 0 here, so the || true
is redundant?
No description provided.