Room version 6 tests

lib/SyTest/Federation/Client.pm

@@ -16,8 +16,7 @@ use SyTest::Assertions qw( :all );
 use URI::Escape qw( uri_escape );
 
 use constant SUPPORTED_ROOM_VERSIONS => [qw(
-   1 2 3 4 5
-   org.matrix.msc2260
+   1 2 3 4 5 6
 )];
 
 sub configure

tests/30rooms/08levels.pl

@@ -7,14 +7,16 @@
 
 sub lockeddown_room_fixture
 {
+   my ( %options ) = @_;
+
    fixture(
       requires => [ $creator_fixture, $user_fixture,
                     qw( can_change_power_levels ) ],
 
       setup => sub {
          my ( $creator, $test_user ) = @_;
 
-         matrix_create_and_join_room( [ $creator, $test_user ] )
+         matrix_create_and_join_room( [ $creator, $test_user ], %options )
          ->then( sub {
             my ( $room_id ) = @_;
 
@@ -154,6 +156,27 @@ sub test_powerlevel
 
                $levels->{$levelname} = 10000000;
             })->main::expect_http_403
-         })->SyTest::pass_on_done( "Fails at setting 75" );
+         })->SyTest::pass_on_done( "Fails at setting 10000000" );
       };
 }
+
+multi_test "Users cannot set notifications powerlevel higher than their own",
+   requires => [ $creator_fixture, $user_fixture, lockeddown_room_fixture( room_version => "6" ),
+                 qw( can_change_power_levels )],
+
+   do => sub {
+      my ( $user, undef, $room_id ) = @_;
+
+      matrix_change_room_power_levels( $user, $room_id, sub {
+         my ( $levels ) = @_;
+
+         $levels->{notifications}{room} = 25;
+      })->SyTest::pass_on_done( "Succeeds at setting 25" )
+      ->then( sub {
+         matrix_change_room_power_levels( $user, $room_id, sub {
+            my ( $levels ) = @_;
+
+            $levels->{notifications}{room} = 10000000;
+         })->main::expect_http_403
+      })->SyTest::pass_on_done( "Fails at setting 10000000" );
+   };

tests/32room-versions.pl

@@ -1,7 +1,7 @@
 use URI::Escape qw( uri_escape );
 
 # We test that some basic functionality works across all room versions
-foreach my $version ( qw ( 1 2 3 4 5 ) )  {
+foreach my $version ( qw ( 1 2 3 4 5 6 ) )  {
    multi_test "User can create and send/receive messages in a room with version $version",
       requires => [ local_user_fixture() ],
 

tests/80torture/20json.pl

@@ -0,0 +1,123 @@
+# Test integers that are outside of the range of [-2 ^ 53 + 1, 2 ^ 53 - 1].
+test "Invalid JSON integers",
+   requires => [ local_user_and_room_fixtures(
+      room_opts => { room_version => "6" }
+   ), ],
+
+   do => sub {
+      my ( $user, $room_id ) = @_;
+
+      Future->needs_all(
+         do_request_json_for( $user,
+            method  => "POST",
+            uri     => "/r0/rooms/$room_id/send/sytest.dummy",
+            content => {
+               msgtype => "sytest.dummy",
+               body    => 9007199254740992,  # 2 ** 53
+            },
+         )->followed_by( \&main::expect_http_400 ),
+
+         do_request_json_for( $user,
+            method  => "POST",
+            uri     => "/r0/rooms/$room_id/send/sytest.dummy",
+            content => {
+               msgtype => "sytest.dummy",
+               body    => -9007199254740992,  # -2 ** 53
+            },
+         )->followed_by( \&main::expect_http_400 ),
+      );
+   };
+
+# Floats should be rejected.
+test "Invalid JSON floats",
+   requires => [ local_user_and_room_fixtures(
+      room_opts => { room_version => "6" }
+   ), ],
+
+   do => sub {
+      my ( $user, $room_id ) = @_;
+
+      do_request_json_for( $user,
+         method  => "POST",
+         uri     => "/r0/rooms/$room_id/send/sytest.dummy",
+         content => {
+            msgtype => "sytest.dummy",
+            body    => 1.1,
+         },
+      )->followed_by( \&main::expect_http_400 );
+   };
+
+# Special values (like inf/nan) should be rejected. Note that these values are
+# not technically valid JSON, but extensions that some programming languages
+# support automatically.
+test "Invalid JSON special values",
+   requires => [ local_user_and_room_fixtures(
+      room_opts => { room_version => "6" }
+   ), ],
+
+   do => sub {
+      my ( $user, $room_id ) = @_;
+
+      my $http = $user->http;
+
+      Future->needs_all(
+         # Try some Perl magic values.
+         do_request_json_for( $user,
+            method  => "POST",
+            uri     => "/r0/rooms/$room_id/send/sytest.dummy",
+            content => {
+               msgtype => "sytest.dummy",
+               body    => "NaN" + 0,
+            },
+         )->followed_by( \&main::expect_http_400 ),
+
+         do_request_json_for( $user,
+            method  => "POST",
+            uri     => "/r0/rooms/$room_id/send/sytest.dummy",
+            content => {
+               msgtype => "sytest.dummy",
+               body    => "inf" + 0,
+            },
+         )->followed_by( \&main::expect_http_400 ),
+
+         do_request_json_for( $user,
+            method  => "POST",
+            uri     => "/r0/rooms/$room_id/send/sytest.dummy",
+            content => {
+               msgtype => "sytest.dummy",
+               body    => "-inf" + 0,
+            },
+         )->followed_by( \&main::expect_http_400 ),
+
+         # Try some Python magic values.
+         $user->http->do_request(
+            method       => "POST",
+            uri          => "/r0/rooms/$room_id/send/sytest.dummy",
+            params       => {
+               access_token => $user->access_token,
+            },
+            content      => '{"msgtype": "sytest.dummy", "body": Infinity}',
+            content_type => "application/json",
+         )->followed_by( \&main::expect_http_400 ),
+
+         $user->http->do_request(
+            method       => "POST",
+            uri          => "/r0/rooms/$room_id/send/sytest.dummy",
+            params       => {
+               access_token => $user->access_token,
+            },
+            content      => '{"msgtype": "sytest.dummy", "body": -Infinity}',
+            content_type => "application/json",
+         )->followed_by( \&main::expect_http_400 ),
+
+         $user->http->do_request(
+            method       => "POST",
+            uri          => "/r0/rooms/$room_id/send/sytest.dummy",
+            params       => {
+               access_token => $user->access_token,
+            },
+            content      => '{"msgtype": "sytest.dummy", "body": NaN}',
+            content_type => "application/json",
+         )->followed_by( \&main::expect_http_400 ),
+      );
+   };