Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use /sync not /events in more places #876

Merged
merged 2 commits into from
May 21, 2020
Merged

Use /sync not /events in more places #876

merged 2 commits into from
May 21, 2020

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented May 21, 2020

Affects:

  • New room members see their own join event
  • Existing members see new members' join events
  • Inbound federation can receive events
  • Inbound federation can receive redacted events

@kegsay kegsay requested a review from neilalexander May 21, 2020 10:30
neilalexander
neilalexander approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kegsay kegsay merged commit 3af537e into develop May 21, 2020
@kegsay kegsay deleted the kegan/sync-not-events2 branch May 21, 2020 10:50
kegsay added a commit to matrix-org/dendrite that referenced this pull request May 21, 2020
@kegsay
Add tests due to matrix-org/sytest#876
91902df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kegsay @neilalexander