This repository has been archived by the owner on May 11, 2023. It is now read-only.
Add query parameter to restrict origin #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. whilst you're in there, perhaps put a comment to explain wtf this file is and what's going on, and link to the synapse instructions of how to host your own, and perhaps the github issue for getting rid of it? |
and an explanatory comment to the file itself
ara4n
suggested changes
Apr 24, 2018
README.md
Outdated
| @@ -4,16 +4,10 @@ UserContent | |||
| A way to render user generated content with a different origin to the main application. | |||
| This can be used to avoid XSS attacks. | |||
|
|
|||
| Version 1 | |||
| --------- | |||
| This is used by Riot to display content in end-to-end encrypted chats. See | |||
There was a problem hiding this comment.
"to display the download button for encrypted attachments" perhaps?
v1.html
Outdated
| attachments into their own origin, away from your Riot. See | ||
| https://github.com/matrix-org/usercontent/blob/master/README.md | ||
| for more info, or https://github.com/vector-im/riot-web/blob/master/README.md#configjson | ||
| if you'd like to host your own. |
There was a problem hiding this comment.
let's add a link to bug 6173 so people can track progress on replacing it with iframes
|
@ara4n PTAL |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.