Maildir capture: added early check. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, I have never seen this PR, I am going to check the code and will merge it asap |
|
@matrixise ping? |
* Use the recommended process_message() signature for smtpd.DebuggingServer to avoid errors like <class 'TypeError'>:process_message() got an unexpected keyword argument 'mail_options' [/usr/lib/python3.8/asyncore.py|read|83] [/usr/lib/python3.8/asyncore.py|handle_read_event|420] [/usr/lib/python3.8/asynchat.py|handle_read|171] [/usr/lib/python3.8/smtpd.py|found_terminator|386] * Be dynamic about what type is the data argument when process_message() is called as with python 3.5 it is `str` where with python 3.8 ist is `bytes` without other changes.
matrixise
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3