Support Implicit type cast for Operators. #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add type conversion logic;
2.support plus,minus,mult,div,mod between each types;
div is integer division; / is division;
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #736
issue #740
issue #782
issue #789
issue #804
What this PR does / why we need it:
Support binary operators (+, -, *, / ,%)(=, !=, >, >=, <, <=) between each types According a type-cast-logic before operator evaluates.
Support NOT unary operator for each types. And fix some bugs while rewriting Not AST.
Support div operator and / operator.
Support Not Operator.
Special notes for your reviewer:
ignore some check while pruning. (toChar function).
Additional documentation (e.g. design docs, usage docs, etc.):
Not Available