Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add log #12000

Merged
merged 10 commits into from
Oct 8, 2023
Merged

add log #12000

merged 10 commits into from
Oct 8, 2023

Conversation

daviszhen
Copy link
Contributor

@daviszhen daviszhen commented Oct 8, 2023

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #11966

What this PR does / why we need it:

在事务创建,commit,rollback处增加出入日志。判断到底卡在哪儿了

@matrix-meow matrix-meow added the size/S Denotes a PR that changes [10,99] lines label Oct 8, 2023
@mergify mergify bot added the kind/test-ci label Oct 8, 2023
@daviszhen daviszhen changed the title 1008 add log add log Oct 8, 2023
Copy link
Contributor

@fengttt fengttt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you just use logger.Info?

@sukki37 sukki37 merged commit 898ac28 into matrixorigin:1.0-dev Oct 8, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/test-ci size/S Denotes a PR that changes [10,99] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants