fix txn leak in cloud env #12028
Merged
fix txn leak in cloud env #12028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w-zr
approved these changes
Oct 9, 2023
fengttt
reviewed
Oct 9, 2023
zhangxu19830126
force-pushed
the
fix_txn_leak
branch
from
d2a3638
to
6df154b
Compare
fengttt
approved these changes
Oct 9, 2023
zhangxu19830126
requested review from
m-schen,
nnsgmsone,
reusee and
daviszhen
as code owners
nnsgmsone
approved these changes
Oct 10, 2023
reusee
approved these changes
Oct 10, 2023
m-schen
approved these changes
Oct 10, 2023
daviszhen
approved these changes
Oct 10, 2023
sukki37
pushed a commit
that referenced
this pull request
Oct 10, 2023
If a cn with the same uuid is restarted within a short period of time, it will lead to the possibility that the remote locks will not be released, because the heartbeat timeout of a remote lockservice cannot be detected. To solve this problem we use uuid+create-time as service id, then a cn reboot with the same uuid will also be considered as not a lockservice. Approved by: @w-zr, @fengttt, @nnsgmsone, @reusee, @m-schen, @daviszhen
sukki37
pushed a commit
that referenced
this pull request
Oct 11, 2023
If a cn with the same uuid is restarted within a short period of time, it will lead to the possibility that the remote locks will not be released, because the heartbeat timeout of a remote lockservice cannot be detected. To solve this problem we use uuid+create-time as service id, then a cn reboot with the same uuid will also be considered as not a lockservice. Approved by: @w-zr, @fengttt, @nnsgmsone, @reusee, @m-schen, @daviszhen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #11966
What this PR does / why we need it:
If a cn with the same uuid is restarted within a short period of time, it will lead to the possibility that the remote locks will not be released, because the heartbeat timeout of a remote lockservice cannot be detected. To solve this problem we use uuid+create-time as service id, then a cn reboot with the same uuid will also be considered as not a lockservice.