Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add lastlog into txn #12374

Merged
merged 23 commits into from
Oct 30, 2023
Merged

add lastlog into txn #12374

merged 23 commits into from
Oct 30, 2023

Conversation

daviszhen
Copy link
Contributor

@daviszhen daviszhen commented Oct 26, 2023 •
edited
Loading

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #11966

What this PR does / why we need it:

打开入口日志，记录sql。

fengttt and others added 10 commits October 1, 2023 21:26
@fengttt
Refactor executeStmt.
f88a622
@fengttt
Revert "Refactor executeStmt."
a42694f 
This reverts commit f88a622.
@daviszhen
Merge branch '1.0-dev' of https://github.com/matrixorigin/matrixone i…
dd64b18 
…nto 1.0-dev
@daviszhen
Merge branch '1.0-dev' of https://github.com/matrixorigin/matrixone i…
26c3cb3 
…nto 1.0-dev
@daviszhen
Merge branch '1.0-dev' of https://github.com/matrixorigin/matrixone i…
b64ed48 
…nto 1.0-dev
@daviszhen
Merge branch '1.0-dev' of https://github.com/matrixorigin/matrixone i…
dae6cb1 
…nto 1.0-dev
@daviszhen
Merge branch '1.0-dev' of https://github.com/matrixorigin/matrixone i…
5e719d6 
…nto 1.0-dev
@daviszhen
fix failure of setting timezone (matrixorigin#12314)
2cd12b4 
保证每次时区都能正确设置成功。

之前设置时区时，值相同时，会拦截。导致没有刷新session中的时区值。

Approved by: @qingxinhome
@daviszhen
Merge branch '1.0-dev' of https://github.com/matrixorigin/matrixone i…
3963d77 
…nto 1.0-dev
@daviszhen
open entrance log
cc19ad1
@matrix-meow matrix-meow added the size/XS Denotes a PR that changes [1, 9] lines label Oct 26, 2023
fengttt
fengttt requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@fengttt fengttt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work. Point select immediate drop 20%.

@daviszhen
Copy link
Contributor Author

This won't work. Point select immediate drop 20%.

......

@matrix-meow matrix-meow added size/S Denotes a PR that changes [10,99] lines and removed size/XS Denotes a PR that changes [1, 9] lines labels Oct 27, 2023
@daviszhen daviszhen changed the title enable entrance log add lastlog into txn Oct 27, 2023
@fengttt
Copy link
Contributor

fengttt commented Oct 30, 2023

This won't work. Point select immediate drop 20%.

......

Do you log EVERY query?

fengttt
fengttt approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@fengttt fengttt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now you know very well that we cannot log TOO much. I will approve based on that the per query log has been removed.

@sukki37 sukki37 merged commit f7e3a11 into matrixorigin:1.0-dev Oct 30, 2023
1 of 2 checks passed
daviszhen added a commit to daviszhen/matrixone that referenced this pull request Jan 22, 2024
@daviszhen
add lastlog into txn (matrixorigin#12374)
1f1431d 
打开入口日志，记录sql。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengttt fengttt fengttt approved these changes

@reusee reusee reusee approved these changes

@zhangxu19830126 zhangxu19830126 zhangxu19830126 approved these changes

@nnsgmsone nnsgmsone nnsgmsone approved these changes

@qingxinhome qingxinhome qingxinhome approved these changes

Assignees
No one assigned
Labels
size/S Denotes a PR that changes [10,99] lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@daviszhen @fengttt @reusee @zhangxu19830126 @nnsgmsone @qingxinhome @sukki37 @matrix-meow