fix long queries that exceed 24 hours #12899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviszhen
requested review from
xzxiong,
qingxinhome and
zhangxu19830126
as code owners
qingxinhome
approved these changes
Nov 22, 2023
zhangxu19830126
approved these changes
Nov 22, 2023
xzxiong
reviewed
Nov 22, 2023
| @@ -240,7 +242,7 @@ func bulkInsert(ctx context.Context, sqlDb *sql.DB, records [][]string, tbl *tab | |||
|
|
|||
| // Use the transaction to execute the SQL command | |||
|
|
|||
| _, execErr := sqlDb.Exec(loadSQL) | |||
| _, execErr := sqlDb.ExecContext(ctx, loadSQL) | |||
There was a problem hiding this comment.
这里要先看看 ctx deadline后，MO对应的 tcp没有的断开的问题，是有可能导致loadSQL 正常完成。SQL执行处于未决状态。
1 task
daviszhen
added a commit
to daviszhen/matrixone
that referenced
this pull request
Nov 27, 2023
如线下沟通，做下面的修改：
1，应用端修改
SetConnMaxLifetime 设置超时。
sqlDb.Exec(loadSQL) 用超时版本
2,goetty 修改
增加超时
msg, err := rs.Read(ReadOptions{超时时间})
3,frontend 打印新conn日志
只打印一条。
目前goroutineid 与 session ip port 无法关联。
Approved by: @qingxinhome, @zhangxu19830126
daviszhen
added a commit
to daviszhen/matrixone
that referenced
this pull request
Nov 27, 2023
如线下沟通，做下面的修改：
1，应用端修改
SetConnMaxLifetime 设置超时。
sqlDb.Exec(loadSQL) 用超时版本
2,goetty 修改
增加超时
msg, err := rs.Read(ReadOptions{超时时间})
3,frontend 打印新conn日志
只打印一条。
目前goroutineid 与 session ip port 无法关联。
Approved by: @qingxinhome, @zhangxu19830126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #1817 https://github.com/matrixorigin/MO-Cloud/issues/1817
What this PR does / why we need it:
如线下沟通，做下面的修改：
1，应用端修改
2,goetty 修改
增加超时
msg, err := rs.Read(ReadOptions{超时时间})
3,frontend 打印新conn日志
只打印一条。
目前goroutineid 与 session ip port 无法关联。