Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix commit an active transaction when drop database #13134

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

YANGGMM
Copy link
Contributor

@YANGGMM YANGGMM commented Nov 30, 2023

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #13132

What this PR does / why we need it:

1.The reason for the previous error is that the table mo_mysql_compatibility_mode is deleted first, and when the database is deleted later, the data will be deleted from this table, which results in the transaction getting stuck.
2.Changing the order of deleting tables now solves the problem

@mergify mergify bot added the kind/bug Something isn't working label Nov 30, 2023
@matrix-meow matrix-meow added the size/S Denotes a PR that changes [10,99] lines label Nov 30, 2023
@mergify mergify bot merged commit bcc89c0 into matrixorigin:main Dec 1, 2023
18 checks passed
YANGGMM added a commit to YANGGMM/matrixone that referenced this pull request Dec 1, 2023
1.The reason for the previous error is that the table mo_mysql_compatibility_mode is deleted first, and when the database is deleted later, the data will be deleted from this table, which results in the transaction getting stuck.
2.Changing the order of deleting tables now solves the problem

Approved by: @qingxinhome
YANGGMM added a commit to YANGGMM/matrixone that referenced this pull request Dec 1, 2023
1.The reason for the previous error is that the table mo_mysql_compatibility_mode is deleted first, and when the database is deleted later, the data will be deleted from this table, which results in the transaction getting stuck.
2.Changing the order of deleting tables now solves the problem

Approved by: @qingxinhome
@YANGGMM YANGGMM deleted the fix-13132 branch January 4, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/S Denotes a PR that changes [10,99] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants